Make Interpreter Heap and Stack Size Configurable #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two configuration settings that adjust the default amount of heap and per-thread stack space for the JVM created to run a Rascal interpreter. Both settings can be either null or numeric. Numeric settings are interpreted as number of MB. The settings correspond to the -Xmx (for heap) and -Xss (for stack) flags passed to the JVM.
…ell. This update modifies the code that computes the maximum heap size to take into account the heap size configuration setting, if set. This also adds new code to compute a maximum stack size, which will use the stack size configuration setting when present or the JVM default when absent.
Updated the names of the configuration parameters and their descriptions to better convey what they are used for. Also updated the code that refers to the parameter names.
|
@DavyLandman and @jurgenvinju tagging you to review and merge if ready. |
jurgenvinju
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to set the maximum heap size and the stack size as VSCode settings. The setting can be added as either a User or Workspace setting. The inputs need to be numeric, but there is no checking to ensure they are sensible right now beyond that (someone could, in theory, enter -5 or 8.1).