New rascal-core & rascal

[DavyLandman]

This brings:

• new typechecker
• various bugfixes in rascal
• the new repl progress bar

to Rascal.

It's still in Draft as stuff doesn't work yet, I just got it to compile.

[jurgenvinju]

Perhaps we can just inline the default method here, because it skips all the monitor variables anyway:

default void registerLocations(IString scheme, IString auth, IMap map) {
	  URIResolverRegistry.getInstance().registerLogical(new LogicalMapResolver(scheme.getValue(), auth.getValue(), map));
	}

  default void unregisterLocations(IString scheme, IString auth) {
    URIResolverRegistry.getInstance().unregisterLogical(scheme.getValue(), auth.getValue());
	}

[DavyLandman]

that would cause a clone of that code, I would rather not.

[jurgenvinju]

This "Loading " job does not have steps. Better remove it; it will make more sense if we leave it to the internal evaluators "loading modules" job.

[jurgenvinju]

There is a doImport call in this method that can now take the entire array of imports as a parameter. So the loop can be dropped and the internal monitor can do each module as a jobStep

[DavyLandman]

I'm going to add job steps, as the reason why this monitor is the top-level one is that it's part of the title of this progress bar. So I want a pretty one, and not one that says which module it's loading (you can still see that in the details.)

[DavyLandman]

Reason's I'm not doing that doImport call:

1. the current code allows me to print a more accurate error message of which root module went wrong
2. the doImport with the varargs is not in a release rascal jar yet, so we can always migrate to that later.

[jurgenvinju]

Just know that every doImport call will now produce its own progress bar; or we go back to the steps without starts situation.

[jurgenvinju]

Note that the exception will tell you which module went wrong anyhow.

[jurgenvinju]

• we can drop the empty "Loading ... " job (see comment)
• use doImport(string array or ...param) instead of looping ourselves for better monitors.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud