Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy calculated JAVA_HOME path to make sure maven works #1771

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

DavyLandman
Copy link
Member

Sometimes rascal is running inside of a jdk that is not the same as JAVA_HOME, or JAVA_HOME is note defined

Fixes #1770

Sometimes rascal is running inside of a jdk that is not the same as JAVA_HOME, or JAVA_HOME is note defined

Fixes #1770
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1771 (1272364) into main (d5dc281) will decrease coverage by 1%.
The diff coverage is n/a.

❗ Current head 1272364 differs from pull request most recent head aa7c0c2. Consider uploading reports for the commit aa7c0c2 to get more accurate results

@@           Coverage Diff           @@
##              main   #1771   +/-   ##
=======================================
- Coverage       48%     48%   -1%     
+ Complexity    5982    5975    -7     
=======================================
  Files          670     670           
  Lines        58304   58310    +6     
  Branches      8496    8496           
=======================================
- Hits         28413   28405    -8     
- Misses       27760   27771   +11     
- Partials      2131    2134    +3     
Impacted Files Coverage Δ
src/org/rascalmpl/library/util/PathConfig.java 0% <ø> (ø)
...calmpl/interpreter/result/SetOrRelationResult.java 82% <0%> (-6%) ⬇️
src/org/rascalmpl/library/util/SemVerLib.java 55% <0%> (-4%) ⬇️
src/org/rascalmpl/unicode/UnicodeDetector.java 63% <0%> (-2%) ⬇️
...g/rascalmpl/interpreter/result/DateTimeResult.java 15% <0%> (-1%) ⬇️
src/org/rascalmpl/interpreter/result/Result.java 13% <0%> (-1%) ⬇️
src/org/rascalmpl/library/Prelude.java 42% <0%> (-1%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DavyLandman DavyLandman merged commit 86ad532 into main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoked maven should be executed in same java environment as rascal itself
2 participants