-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved type maximal sharing lookup #131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demote to weak reference if not used for a certain period Related to #130
DavyLandman
changed the title
Improved type maximal sharing lookup (related to #130)
Improved type maximal sharing lookup
Oct 9, 2021
But do cleanup and demotion in the maintenance thread
… null annotations
ok; the code looks absolutely fine. The non-functional properties I have no idea how to gauge on short notice, so I'm deferring this to @DavyLandman ; we are promising ourselves to evaluate this design in terms of CPU efficiency, thread-safety and memory efficiency in the near future. I'll make an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130.
This simplifies the code and makes it faster in the hot-path.
After finishing the migration to java 11, we can test out the performance gains of this change by making a new release of vallang.
Thanks @ben-manes for the discussion and the suggestions in issue #130.