Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix black pre-commit hook import error #250

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

abaisero
Copy link
Contributor

Problem: Older versions of black were (for some reason) importing
internal modules from the click package. Recent internal updates to
the click package now cause black to fail (see
psf/black#2964).

Solution: Two approaches exist. Either fix the version of click to a
previous version, or update the version of black. This commit updates
the version of black, and reruns black on all files.

Problem:  Older versions of `black` were (for some reason) importing
internal modules from the `click` package.  Recent internal updates to
the `click` package now cause `black` to fail (see
psf/black#2964).

Solution:  Two approaches exist.  Either fix the version of `click` to a
previous version, or update the version of `black`.  This commit updates
the version of `black`, and reruns black on all files.
@abaisero abaisero requested a review from a team as a code owner April 10, 2022 04:14
@abaisero
Copy link
Contributor Author

abaisero commented Apr 10, 2022

This pull request should also fix the failed lint / pre-commit github-actions job.

Copy link
Member

@amj amj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this!

@amj amj merged commit dd75a1b into usgo:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants