GetErrorStringLineCount and GetErrorStringLine return empty lines for some errors

[scharlton2]

Example:

id = CreateIphreeqc()

if (id .LT. 0) stop

res = SetErrorStringOn(id, .TRUE.)

res = LoadDatabase(id, 'phreeqc.dat')

res = AccumulateLine(id,"SOLUTION")
res = AccumulateLine(id,"pH abc")
res = AccumulateLine(id,"xx")

res = RunAccumulated(id)

if (res .NE. 0) then
   do i = 1, GetErrorStringLineCount(id)
      call GetErrorStringLine(id,i,Line)
      write (*,'(I0,1x,A)') i, trim(line)
   enddo
endif

write (*,'(/"Returned accumulating line with ",I0," errors."/)') res

Outputs:

1
2 ERROR: Concentration data error for ph in solution input.
3
4 ERROR: No element or master species given for concentration input.
5 ERROR: Calculations terminating due to input errors.

Returned accumulating line with 2 errors.

Cause

Empty line is added here (Line 42):

iphreeqc/src/phreeqcpp/common/PHRQ_base.cxx

Lines 32 to 56 in cfe6dec

	void PHRQ_base::
	error_msg(const std::string & stdstr, int stop)
	{
	this->base_error_count++;
	std::ostringstream msg;
	msg << "ERROR: " << stdstr << "\n";
	if (this->io)
	{
	this->io->output_msg(msg.str().c_str());
	this->io->log_msg(msg.str().c_str());
	this->io->error_msg("\n");
	this->io->error_msg(msg.str().c_str(), stop!=0);
	}
	else
	{
	#if !defined(R_SO)
	std::cerr << msg.str().c_str();
	std::cout << msg.str().c_str();
	#endif
	}
	if (stop != 0)
	{
	throw PhreeqcStop();
	}
	}

Proposed fix

modify IPhreeqc::update_errors to skip calling this->ErrorLines.push_back(line); for empty lines.