Ushahidi should not upsize uploaded images, only downsize them.

[solarissmoke]

When you upload an image with a report, it is forcibly resized to fit Ushahidi's large/medium/thumb formats. However this means that small images are upsized to fit these dimensions.

I am not sure if this is intentional, but it results in a lossy, pixelated image being saved, and it would be much better from a user experience perspective to just save and display the original image instead.

[rjmackay]

I think this makes sense. Just to confirm, this still saves images for media_link, media_medium and media_thumb? and saves valid filenames in the media table?
Could you just save the image once at full size and then reuse that url for all 3 sizes? (or 2 if its still big enough for medium)

[solarissmoke]

@rjmackay it was saving three images (even if they were all the same size), but I have now changed it so that it reuses the larger format if it is small enough. The media table is populated correctly for each size (even when two sizes point to the same file).

For a 275 x 183 image, the following files are written to disk:

3_1_1370314420.jpg (full size, 275 x 183)
3_1_1370314420_t.jpg (thumbnail, 89 x 59)

a medium size image is not created because the full size one is small enough.

...and the media table looks like this:

media_link: 3_1_1370314420.jpg
media_medium: 3_1_1370314420.jpg (i.e., same as media_link)
media_thumb: 3_1_1370314420_t.jpg

Have also done the same thing for the video thumbnails.

[rjmackay]

@aoduor @srutto Pretty sure this is good. Could one of you test this change?
Make sure to test both photo and video thumbnails and images of various sizes (otherwise you won't hit all the possible resize paths)

[rjmackay]

I'm going to merge this.. but @srutto please flag this for testing in 2.7.1
ping @kamaulynder can you chase this too?

[srutto]

@rjmackay noted