Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto upgrader issues #716

Closed
rjmackay opened this issue Jul 18, 2012 · 15 comments
Closed

Auto upgrader issues #716

rjmackay opened this issue Jul 18, 2012 · 15 comments
Assignees
@kamaulynder
Labels
Bug

Comments

@rjmackay
Copy link
Contributor

A couple of issues in the auto upgrader:

  1. It looks like it tries to run every upgrade script, not just the ones from the current version on..
    https://github.com/ushahidi/Ushahidi_Web/blob/v2.5b/application/controllers/admin/upgrade.php#L358
  2. The installer uses the new settings table, but it might need to support both old an new formats during the update process.. not sure.
@kamaulynder
Copy link
Contributor

working on the upgrader when I wake up so should address the problems.

On Thu, Jul 19, 2012 at 1:08 AM, Robbie MacKay <
reply@reply.github.com

wrote:

A couple of issues in the auto upgrader:

  1. It looks like it tries to run every upgrade script, not just the ones
    from the current version on..

https://github.com/ushahidi/Ushahidi_Web/blob/v2.5b/application/controllers/admin/upgrade.php#L358
2. The installer uses the new settings table, but it might need to support
both old an new formats during the update process.. not sure.

Reply to this email directly or view it on GitHub:
#716

Too brief? Here's why! http://emailcharter.org
Regards
Linda Kamau
Coder!!

rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Jul 18, 2012
@rjmackay
Upgrader fixes - needs full upgrade test still ushahidi#716
4ffad6d 
* Fix empty query error due to new line after last ; in sql script
* Don't run ALL upgrade scripts, just  the relevant one
* Support both old and new settings table
* Special case support for db version < 11
@rjmackay
Copy link
Contributor Author

OK - this commit might get some of it: rjmackay@4ffad6d
Haven't pushed to the main repo at all yet.. I was working on #715 but stuck for now so back to project work.

@ghost ghost assigned kamaulynder Jul 20, 2012
@rjmackay
Copy link
Contributor Author

@kamaulynder you're on this already right?

@kamaulynder
Copy link
Contributor

ok, could you push to the repo. that way we test it out.

@rjmackay
Copy link
Contributor Author

Pushed all my stuff on Monday. Assuming your testing and fixing the rest..

@kamaulynder
Copy link
Contributor

perfect, thanks.

On Tue, Jul 24, 2012 at 10:50 AM, Robbie MacKay <
reply@reply.github.com

wrote:

Pushed all my stuff on Monday. Assuming your testing and fixing the rest..

Reply to this email directly or view it on GitHub:
#716 (comment)

Too brief? Here's why! http://emailcharter.org
Regards
Linda Kamau
Coder!!

@rjmackay
Copy link
Contributor Author

ah ok.. might be only on develop branch.. cherry-pick 4ffad6d onto v2.5b if you need it

rjmackay added a commit that referenced this issue Jul 24, 2012
@rjmackay @kamaulynder
Upgrader fixes - needs full upgrade test still #716
b8b1fe5 
* Fix empty query error due to new line after last ; in sql script
* Don't run ALL upgrade scripts, just  the relevant one
* Support both old and new settings table
* Special case support for db version < 11
@kamaulynder
Copy link
Contributor

cherry-picking done!

@rjmackay rjmackay reopened this Jul 25, 2012
@rjmackay
Copy link
Contributor Author

Reopening this to cover further upgrader issues

rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
Upgrader: don't expect files in ushahidi/ subdir #716
c82de39 
Previous updates haven't had this subdir in the zip file
but the upgrader seems to think they should.
rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
Replace complicated try-catch for getting db_version with kohana::con…
0e00798 
…fig() call #716
rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
Handle old settings DB schema gracefully #716
4347f76 
During upgrade we need to be able to bootstrap Ushahidi and hit the
upgrade controller without any errors even though the DB is out of date.
To do this we're checking for the 'key' field in the setting helper
functions and running old/new queries as appropriate.

Signed-off-by: Robbie Mackay <rm@robbiemackay.com>
rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
Fix http_client call to download ushahidi updates #716
339800e
rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
Clear settings cache if not an array #716
fa9757e 
This is to handle upgrading from 2.4 where settings in cache was an object
rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
Upgrader: clear cache after new files copied over #716
c35572d
rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
Upgrader: don't copy ushahidi.zip #716
84faae3 
No need to copy the source zip file over
rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
More logging on db updates #716
9e44722
rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
Revert "Upgrader: don't expect files in ushahidi/ subdir #716"
5e734e1 
The gen_updates.sh script has now been updated to package files inside
an ushahidi/ subdirectory. This means we can still work with older versions

This reverts commit c82de39.
rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
Revert "Upgrader: don't copy ushahidi.zip #716"
0b4e674 
This reverts commit 84faae3.
rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
Upgrader: Fix SQL upgrades #716
c06a780 
* Run SQL upgrades from docroot rather than than upgrade dir
* Fix botched change to get_setting()
* Bump up execution time for sql upgrades, just in case
* Avoid infinite loop when version not returned
* Revert to manually getting db_version from settings table
rjmackay added a commit that referenced this issue Jul 25, 2012
@rjmackay
Halt upgrader on server errors #716
70e1905
rjmackay added a commit that referenced this issue Jul 26, 2012
@rjmackay
Add support for removing old files during upgrade #716
a655e10
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Jul 26, 2012
@rjmackay
Upgrader: clear cache after new files copied over ushahidi#716
1e67da7 
Prevent Kohana saving its caches on shutdown ushahidi#716
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Jul 26, 2012
@rjmackay
Add support for removing old files during upgrade ushahidi#716
7bbb993
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Jul 26, 2012
@rjmackay
Fixing DB upgrades ushahidi#716
d20ac17
rjmackay added a commit that referenced this issue Jul 26, 2012
@rjmackay
Add support for removing old files during upgrade #716
aaf000b
rjmackay added a commit that referenced this issue Jul 26, 2012
@rjmackay
Remove unneeded call to new_schema #716
421c794
rjmackay added a commit that referenced this issue Jul 28, 2012
@rjmackay
Fix settings calls to new_schema() #716
2a75fe7
@PoPoutdoor
Copy link

Upgrader repeat asking for update on commit d30c5b8 [V2.5b], have to fixed by manual set db_version to 96.

@rjmackay
Copy link
Contributor Author

Screenshot?
I'm not seeing this issue, pretty sure it should have been fine after 2b482ee. Try clearing your cache and then check again..

@rjmackay rjmackay closed this as completed Aug 8, 2012
@aoduor aoduor reopened this May 2, 2013
@gcameron89777
Copy link

screen shot 2013-05-02 at 2 19 17 pm
I tried to update today when I saw the notice in my dashboard "Version 2.7 available". I clicked continue, entered my FTP info then was taken to the attached screen. This screen has remained like this for about an hour now. I'm not sure if it just takes a while or not.

@eyedol
Copy link
Collaborator

eyedol commented May 3, 2013

@gcameron89777 Make sure you're using the auto-upgrader plugin and if the plugin ask for your ftp details, make sure you provide the correct host username and password. Also your ftp user must be able to manipulate the installed Ushahidi files in your web root folder

@gcameron89777
Copy link

Ah. Installed updater plugin and now updated. The confusion was that the
upgrade prompt still appeared on my dashboard without the updater. Cheers!

On Fri, May 3, 2013 at 4:09 PM, Henry Addo notifications@github.com wrote:

@gcameron89777 https://github.com/gcameron89777 Make sure you're using
the auto-upgraderhttps://github.com/eyedol/Ushahidi-plugin-auto-upgraderplugin and if the plugin ask for your ftp details, make sure you provide
the correct host username and password. Also your ftp user must be able
to manipulate the installed Ushahidi files in your web root folder

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/716#issuecomment-17415408
.

best
Gavin Cameron
647.832.8626

@kamaulynder
Copy link
Contributor

This is fixed, the auto-upgrader -> https://github.com/eyedol/Ushahidi-plugin-auto-upgrader plugin works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamaulynder kamaulynder

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rjmackay @eyedol @kamaulynder @aoduor @PoPoutdoor @gcameron89777