Fixing boolean check for stats (Issue #1270) #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaf1a69 half fixed the issue with connection problems. The check for $xml == false is always true, and so the stat_id and stat_key returned by the tracker are never saved on the database. This never lets new deployments get their stats started.
Closed
|
@ditorelo thank for your help but i don't understand how to fix this bug, what is the file where found "xml==false", can you explain please. Thank. |
|
Hi @hniamkey, Maybe have a look at ditorelo@9e8dd03 - you have to update the file |
|
@diletero hop excuse me i don't make attention to the link below. Awesome bug fix. Thank. |
rjmackay
added a commit
that referenced
this pull request
Nov 4, 2013
Fixing boolean check for stats (Issue #1270)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eaf1a69 half fixed the issue with connection problems.
The check for $xml == false is always true, and so the stat_id and stat_key returned by the tracker are never saved on the database. This never lets new deployments get their stats started.