fix:Replacing-no-posts-yet-text #815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Outreachy Task Submission |
Angamanga
requested changes
Mar 13, 2024
There was a problem hiding this comment.
Thank you for your PR @jatinder14! Could you double-check so that string you changed are not used in other instances, for example, when there are actually no posts available? I suspect it is used in more cases, for example when there are no posts in a deployment, and then the text is actually correct. So there needs to be some logic added for when to show what text.
jatinder14
force-pushed
the
Replacing-no-posts-yet-text
branch
from
28a02ed
to
37f06bf
Compare
|
@Angamanga can you please check it again ? |
Angamanga
requested changes
Mar 18, 2024
|
@Angamanga can you please check it again ? |
Angamanga
approved these changes
Mar 25, 2024
|
@Angamanga To consider for next release |
|
please merge it @Angamanga |
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4735