Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4734] Change Confirmation message text #825

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

goodylove
Copy link

@goodylove goodylove commented Mar 6, 2024

Description

This pull request addresses the issue of unclear confirmation message text by updating it to provide users with more informative feedback.

Changes Made

  • Updated confirmation message text from "Post Status have been changed" to "Post Status Changed"
    • Old Text: "Post Status have been changed"
    • New Text: "Post Status Changed"

Testing

I have tested the updated confirmation message text by:

  • Verifying its display in various scenarios.
  • Ensuring it aligns with the expected message text.

@Angamanga
Copy link
Contributor

Thank you for your PR @goodylove 🙏. Could you please add a short description and a checklist for testing the fix as well and then we'll review it 👍

@goodylove
Copy link
Author

Thank you for your PR @goodylove 🙏. Could you please add a short description and a checklist for testing the fix as well and then we'll review it 👍

ok i will do that now

@goodylove
Copy link
Author

goodylove commented Mar 14, 2024

@Angamanga i have updated my PR

@Angamanga Angamanga requested a review from webong March 15, 2024 14:19
@Angamanga
Copy link
Contributor

@webong Could you please review?

@Angamanga
Copy link
Contributor

@webong Reminding you to review this PR 👍

Copy link
Collaborator

@webong webong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes code review check ... only thing is I don't see how the old notification message is quite unclear compared to the new one.

Feels the same to me, in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants