[Outreachy Task Submission] Remove Extra Focus From Add Buttons On Keyboard Navigation #982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4902
Description
Currently the add new buttons behave weirdly when navigating using just keyboard. The button has to be tabbed twice before it responds to the enter event.
Why does this happen?
This happens because the mizima-client-buttons in this cases are router links and router links come with their own focus when tabbed into, so this focus + the buttons default focus results in tabbing twice before the button responds to the enter event.
Fix
Set tabindex to -1 on mizima-client-buttons when it's being used as a router link to prevent this extra focus.
How to test
This fix covers surveys, users, roles, categories, webhooks and data sources
@Angamanga This pr is ready for review 馃檹馃徑