Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outreachy task submission] lack of confirm password field during sign up #4880 #984

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

mo-gbolahan
Copy link

Description:
This pull request addresses the issue of the sign-up form lacking a "Confirm Password" field, which currently makes it challenging for users to ensure the accuracy of their chosen password during registration. By adding a "Confirm Password" field, users will be able to verify their password input, reducing the likelihood of errors and enhancing the overall user experience.

Changes Made:

  • Added a "Confirm Password" field to the sign-up form.
  • Updated form validation logic to ensure that the password and confirm password fields match before allowing form submission.
  • Implemented error messaging to prompt users to re-enter their password if the passwords do not match.

Testing:

  • Verify that the "Confirm Password" field is displayed next to the "Password" field in the sign-up form.
  • Test entering matching passwords in both fields and ensure the form submission is successful.
  • Test entering mismatching passwords and verify that appropriate error messages are displayed prompting the user to re-enter their password.
  • Conduct usability testing to assess the clarity and ease of use of the updated sign-up form.
  • Ensure that the form validation logic correctly prevents form submission if the passwords do not match.
  • Test the responsiveness of the sign-up form across different screen sizes and devices.

Related Issue:
ushahidi/platform#4880

Reviewer:
@Angamanga

This pull request aims to enhance the usability and accuracy of the sign-up process by adding a "Confirm Password" field to the form. Your feedback and review are greatly appreciated. Thank you!

Copy link
Member

@tuxpiper tuxpiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a couple things:

  1. A small issue with the files that you committed.

  2. It looks like the "Passwords do not match" is not really showing up. Can you please check?
    Screenshot 2024-04-02 at 21 31 31

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change. It's not useful to others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants