Fixes deployment details disappearing upon Changing and Saving #993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed in issue#4898 when attempting to modify and save the deployment name, logo, or description within the deployment settings, an unexpected issue occurs where all deployment details disappear. And only when the user refreshes the page the deployment details reappear.
this happened because in
general.component.ts
this was returnedwhen infact it should've returned
updatedSite.result
As you can notice in screenrecording below, the site deployment details does not vanish anymore
Recording.2024-03-31.183828.mp4