Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes deployment details disappearing upon Changing and Saving #993

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

nimishmedatwal
Copy link
Contributor

As noticed in issue#4898 when attempting to modify and save the deployment name, logo, or description within the deployment settings, an unexpected issue occurs where all deployment details disappear. And only when the user refreshes the page the deployment details reappear.

this happened because in general.component.ts this was returned

return this.configService.update('site', siteConfig).pipe(
      mergeMap((updatedSite) => {
        this.sessionService.setConfigurations('site', updatedSite);
        return this.configService.update('map', this.mapSettings.mapConfig);
      }),

when infact it should've returned updatedSite.result
As you can notice in screenrecording below, the site deployment details does not vanish anymore

Recording.2024-03-31.183828.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant