Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #2383 dual dropdowns #1353

Merged
merged 3 commits into from Oct 30, 2019
Merged

fixed issue #2383 dual dropdowns #1353

merged 3 commits into from Oct 30, 2019

Conversation

c3ho
Copy link
Contributor

@c3ho c3ho commented Oct 24, 2019

This pull request makes the following changes:

  • removed dual dropdown when selecting languages
  • removed toggle for first language selection option and svg

Testing checklist:

  • verified I could still reach and see second dropdown, first drop down toggle id now disabled

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

@ushbot
Copy link
Collaborator

ushbot commented Oct 24, 2019

Hey @c3ho,
thank you for your Pull Request.

It looks like you haven't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@c3ho
Copy link
Contributor Author

c3ho commented Oct 24, 2019

[clabot:check]

@ushbot
Copy link
Collaborator

ushbot commented Oct 24, 2019

@rjmackay It looks like @c3ho just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@Angamanga
Copy link
Collaborator

Thank you so much @c3ho! I will review and get back to you!

@Angamanga Angamanga self-requested a review October 24, 2019 17:17
Copy link
Contributor

@rowasc rowasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @c3ho

@rowasc rowasc merged commit a483ac0 into ushahidi:develop Oct 30, 2019
@rowasc
Copy link
Contributor

rowasc commented Oct 30, 2019

FYI @Angamanga this passed just fine locally, so I'm sending it to @Obadha2 in the test environment for a testing round with multiple languages.

@rowasc
Copy link
Contributor

rowasc commented Oct 30, 2019

@allcontributors add c3ho for code

@AmTryingMyBest
Copy link
Contributor

@rowasc this passes qa on test environment. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants