Fix settings survey route not accessible from mode-context

[Ifycode]

This pull request makes the following changes

• Fixes Settings survey route not accessible from mode-context platform#4299

Details

• Settings module is lazy loaded depending on where user clicks first (mode-bar or mode-context link)

Screenshots

Testing checklist

• Settings module is lazy loaded when "settings" link is clicked on from the mode-bar
• Settings module is lazy loaded when "create new survey" link is clicked on from the mode-context
• Settings module is lazy loaded when "survey settings" button/link is clicked on, from the small dropdown in the mode-context
• I certify that I ran my checklist

Ping @ushahidi/platform

[Ifycode]

@Angamanga can you take a look at this pull request when you have time?

[Ifycode]

@Angamanga Another place in the mode-context doesn't work. I've fixed it too (screenshots above). Ready for review when you're back.

[Angamanga]

Break out lazy-load function, then approved!

[Ifycode]

I've made the change @Angamanga. So moving all those routes from settings-list.routes into the settings.routes file works, but the size for settings bundle is reduced from 1.5mb to about 700kb. The size of the ushahidi-legacy-app bundle is back up to 11.2mb. That's what I observed.

[Angamanga]

@Ifycode Ok lets go with the original plan for now and skip my idea :D Sorry for the confusion...

[Ifycode]

I've pushed a new change where I merged the two ideas @Angamanga you can check and test it now.

[Angamanga]

Approved!

[Angamanga]

Nice solution!