Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make modebar a separate module #1696

Merged
merged 5 commits into from Aug 10, 2021

Conversation

Ifycode
Copy link
Member

@Ifycode Ifycode commented Aug 6, 2021

This pull request makes the following changes:

Testing checklist:

  • Modebar shows up and everything related to it functions fine.

  • I certify that I ran my checklist

Ping @ushahidi/platform

@Ifycode
Copy link
Member Author

Ifycode commented Aug 6, 2021

@Angamanga please help review.

Copy link
Collaborator

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) Approved!

@Angamanga Angamanga merged commit bdec8cc into ushahidi:feature/migration Aug 10, 2021
@Ifycode Ifycode deleted the isolate-modebar branch August 12, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants