Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services: Move unshared from common module - batch 1 #1701

Merged
merged 3 commits into from Aug 31, 2021

Conversation

Ifycode
Copy link
Member

@Ifycode Ifycode commented Aug 16, 2021

This pull request makes the following changes:

Not shared services (moved)

Map Data Activity Settings Modebar Auth Common Services Moved
  • ViewHelper
  • MessageEndpoint
  • TermsOfServiceEndpoint
  • ApiKeyEndpoint
  • UserSettingsEndpoint
  • FormRoleEndpoint
  • FormStageEndpoint
  • FormContactEndpoint
  • WebhookEndpoint
  • PermissionEndpoint
  • DataProviderEndpoint
  • CountryCodeEndpoint
  • HxlLicenseEndpoint
  • HxlMetadataEndpoint
  • HxlOrganisationsEndpoint
  • AccessibilityService
  • HxlExport

Testing checklist:

  • The above unshared services are moved from common module, and breaks nothing in the application
  • I certify that I ran my checklist

Ping @ushahidi/platform

@Ifycode Ifycode marked this pull request as draft August 16, 2021 04:50
@Ifycode Ifycode marked this pull request as ready for review August 16, 2021 05:56
@Ifycode
Copy link
Member Author

Ifycode commented Aug 16, 2021

@Angamanga This is ready for review too.

@Angamanga
Copy link
Collaborator

@Angamanga Test + merge

@Angamanga Angamanga changed the base branch from feature/migration to develop August 20, 2021 07:37
@Angamanga Angamanga changed the base branch from develop to feature/migration August 20, 2021 07:38
@Angamanga Angamanga merged commit cb27c92 into ushahidi:feature/migration Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants