Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing data-module with SystemJS syntax #1753

Merged
merged 1 commit into from Nov 12, 2021
Merged

Importing data-module with SystemJS syntax #1753

merged 1 commit into from Nov 12, 2021

Conversation

Angamanga
Copy link
Collaborator

@Angamanga Angamanga commented Nov 12, 2021 •
edited

This pull request makes the following changes:

  • Importing data-module with SystemJS import-map instead of filename

Testing checklist:

  • Go to Map view page/Data view page.

  • Click on the + sign to open list of surveys to select one to submit response to.

  • Click on any one survey

  • The form for the survey opens

  • I certify that I ran my checklist

Fixes ushahidi/platform#4382 .

Ping @ushahidi/platform

tuxpiper
tuxpiper approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@tuxpiper tuxpiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I also didn't find any other remaining similar patterns in the code.

@tuxpiper tuxpiper merged commit ed599eb into develop Nov 12, 2021
@tuxpiper tuxpiper deleted the import-data-module branch November 12, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxpiper tuxpiper tuxpiper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Angamanga @tuxpiper