Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long, single word report titles break the postcard layout #2271

Closed
5 tasks
justinscherer opened this issue Nov 1, 2017 · 5 comments · Fixed by ushahidi/platform-pattern-library#249
Closed
5 tasks
Assignees
Labels
Bug Codebase: Client Indicates issue work will be in client Theme: Data View
Milestone

Comments

@justinscherer
Copy link

justinscherer commented Nov 1, 2017

Expected behaviour

card inactive

Actual behaviour

screen shot 2017-10-26 at 8 44 43 am

Steps to reproduce the behaviour/error

find a post with a really long, 1-word title.

Where

Aha! Link: https://ushahiditeam.aha.io/features/PROD-494

@kinstella
Copy link
Contributor

Copied comments from #2272 for reference to line-clamping specification:

What should the rules be for wrapping/ellipses-ing the title text? Should there be a relative width cutoff, or maybe a total number of characters?
2 lines then ellipses before the chevron. It should never wrap more than once before being truncated.

@jshorland jshorland removed the 2chaguzi label Mar 1, 2018
@rowasc rowasc removed this from the UX clean up milestone Sep 13, 2018
@rowasc rowasc added Theme: Data View Codebase: Client Indicates issue work will be in client and removed P2 - Normal labels Jun 11, 2019
@rowasc rowasc added this to the Parking Lot milestone Sep 4, 2020
@rowasc rowasc modified the milestones: Parking Lot, Hacktoberfest Oct 13, 2020
@rowasc rowasc added the Community Task Issues that the Ushahidi OSS community is encouraged to contribute to label Oct 13, 2020
@rowasc
Copy link
Contributor

rowasc commented Oct 13, 2020

related ticket #2272 can be done after fixing this one (so if you request this issue, you can also claim the related one)

@firenz
Copy link

firenz commented Oct 15, 2020

Hello @rowasc @Angamanga, can you assign me this issue? I think I can fix it.

@Angamanga
Copy link
Contributor

@firenz Yes, please go ahead! I think it needs to be fixed in the pattern-library. Check the setup here if you haven't already: https://docs.ushahidi.com/platform-developer-documentation/development-and-code/setup_alternatives/setting-up-the-pattern-library-for-development

@Angamanga Angamanga removed the Community Task Issues that the Ushahidi OSS community is encouraged to contribute to label Oct 16, 2020
@firenz
Copy link

firenz commented Oct 19, 2020

@Angamanga I just made the PR, check it whenever you can, please ☺️

@tuxpiper tuxpiper moved this from Accepted to Released in Release track next up... 5.2.1 Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Codebase: Client Indicates issue work will be in client Theme: Data View
Development

Successfully merging a pull request may close this issue.

8 participants