Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter pane does not scroll to the top when it is closed and re-opened #2347

Open
5 tasks
justinscherer opened this issue Dec 5, 2017 · 7 comments
Open
5 tasks
Assignees
Labels
Bug Codebase: Client Indicates issue work will be in client Theme: Filters & Search
Milestone

Comments

@justinscherer
Copy link

justinscherer commented Dec 5, 2017

Expected behaviour

Open filter pane, scroll, apply a filter. filter pane closes, re-open filter pane, filterpane is scrolled to the top.

Actual behaviour

Open filter pane, scroll, apply a filter. filter pane closes, re-open filter pane, filterpane is NOT scrolled to the top. It is at the same scroll location as it was when I applied the filters and closed the filter pane.

Steps to reproduce the behaviour/error

Open filter pane, scroll, apply a filter. filter pane closes, re-open filter pane

Where

Aha! Link: https://ushahiditeam.aha.io/features/PROD-468

@Angamanga Angamanga added Codebase: Client Indicates issue work will be in client Community Task Issues that the Ushahidi OSS community is encouraged to contribute to and removed P2 - Normal labels Apr 29, 2019
@rowasc
Copy link
Contributor

rowasc commented Jun 11, 2019

Demo of current behavior for reference.
Jun-10-2019 23-50-53fp

@Erioldoesdesign
Copy link

I actually don't think this is bad in the circumstance that: You haven't navigated to another 'thing' clicked a post in the map/data list, shared data etc.

The filter panel should reset to the top if you 'complete' your action but not if you almost immediately reopen it.

So, the 'back to top' functionality should be based on time not in filter panel and 'has something else been interacted with'

/my two cents

@rowasc rowasc added this to the Parking Lot milestone Sep 4, 2020
@vanessa-ariel
Copy link

Hi @Angamanga, can I be assigned to this issue?

@rowasc
Copy link
Contributor

rowasc commented Oct 12, 2020

hey @vanessa-ariel I assigned #1029 instead. Thanks

@Angamanga
Copy link
Contributor

@Dev-Som check out this issue instead!

@Dev-Chisom
Copy link

@Angamanga Thanks, I'll start working on it.

@rowasc rowasc modified the milestones: Parking Lot, Hacktoberfest Oct 16, 2020
@rowasc rowasc removed the Community Task Issues that the Ushahidi OSS community is encouraged to contribute to label Oct 16, 2020
@rowasc
Copy link
Contributor

rowasc commented Oct 16, 2020

@Dev-Som assigned! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Codebase: Client Indicates issue work will be in client Theme: Filters & Search
Projects
None yet
Development

No branches or pull requests

7 participants