Check labelling for logging in and signing up users

[Angamanga]

There are two ways labels are handled in the platform, depending on the markup of the form:

<label for="username">Username</label>
<input id="username" type="text" />

and

<label>Username
     <input id="username" type="text" />
</label>

Go through the following forms and make sure the element is either using the for-attribute to associate the form-control or is encapsulating the form-control like the second example.

The login and sign-up forms are found when clicking on Login and Signup in the lefthand mode-bar:

The forgot-password-form is found when clicking on "Forgot password" in the login-form:

The files related to the above form is found here:

• https://github.com/ushahidi/platform-client/blob/develop/app/common/auth/login.html
• https://github.com/ushahidi/platform-client/blob/develop/app/common/auth/password-reset-confirm.html
• https://github.com/ushahidi/platform-client/blob/develop/app/common/auth/password-reset.html
• https://github.com/ushahidi/platform-client/blob/develop/app/common/auth/register.html

If no adjustments is needed, just comment in this issue that you have worked through the issues and checked, if adjustment is needed, make the necessary changes and create a PR 🎉 If changes are needed, make sure the form still looks the same as before and that is has no effect on the visual appearance of the form.

Aha! Link: https://ushahiditeam.aha.io/features/PROD-836

[Akshansh99]

Can I work on this?

[Akshansh99]

I've checked all the mentioned files and no further adjustment is required.

[niksseif]

Hi there,
I went through all the files mentioned above and all the labels have for attribute same as the id of input field.

[Angamanga]

@Akshansh99 @niksseif Thank you for your contribution 🎉 !

[Angamanga]

@all-contributors please add @Akshansh99 for ally

[allcontributors]

@Angamanga

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

[Angamanga]

@all-contributors please add @Akshansh99 for a11y

[allcontributors]

@Angamanga

I've put up a pull request to add @Akshansh99! 🎉

[Angamanga]

@all-contributors please add @niksseif for a11y

[allcontributors]

@Angamanga

I've put up a pull request to add @niksseif! 🎉

[error404-sp]

Hi @Angamanga ,
I came across this project from the outreachy website and found it interesting. I went through the given links and found that some minimal adjustments can be made to improve accessibility.
I will like to be assigned this issue.
Could you please provide the docs to set up environment if it's necessary in this project.

[Angamanga]

@error404-sp Please go ahead :) Here is the docs for the environment: https://app.gitbook.com/@ushahidi/s/platform-developer-documentation/, check especially these pages for setting up the dev-environment:
https://app.gitbook.com/@ushahidi/s/platform-developer-documentation/development-and-code/setup_alternatives#platform-api-backend-install-guides

and

https://app.gitbook.com/@ushahidi/s/platform-developer-documentation/development-and-code/setup_alternatives#platform-client-frontend-install-guides

Let me know if you run into problems and need guidance!

[error404-sp]

Hi @Angamanga ,
I have created the changes in the above files. Kindly review it.
ushahidi/platform-client#1554 (comment)
I would really appreciate feedback on it.
I have refered to the W3C standards for the changes.
Thanks

[Angamanga]

@error404-sp Thank you for your contribution! I will review shortly!

[TunrayoIlawole]

Can I work on this?

[rowasc]

@TunrayoIlawole Hey. There's already someone working on it, so in this case, no. However you can check the other tickets in the hacktoberfest and outreachy labels. Thank you!

[tuxpiper]

@all-contributors please add @error404-sp for code

[allcontributors]

@tuxpiper

I've put up a pull request to add @error404-sp! 🎉