Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add img role in all svg images to improve accessibility. #4130

Closed
renujain31 opened this issue Oct 20, 2020 · 12 comments · Fixed by ushahidi/platform-client#1593 or ushahidi/platform-client#1659

Comments

@renujain31
Copy link
Collaborator

renujain31 commented Oct 20, 2020

Description:

When using embedded SVG images, it is a good idea to set role="img" on the outer element and give it a label.
This will cause screen readers to just consider it as a single entity and describe it using the label, rather than trying to read out all the child nodes.

Todo:

Search for <svg class="iconic" in the *.html files of platform-client codebase and replace it with <svg class="iconic" role="img". It involves changes at approximately 260 lines and 79 files so make sure that the UI is not affected.

Aha! Link: https://ushahiditeam.aha.io/features/PROD-879

@AishaSaman
Copy link

I would like to take this. If it's available

@amycruz97
Copy link

can i work on this pls

@bukolabisuga
Copy link

Hi @Angamanga I'd love to work on this. Thank you!

@ghost
Copy link

ghost commented Oct 20, 2020

@renujain31 can I work on this? I'm an outreachy applicant!

@amadikwajoyn
Copy link

@Angamanga please let me work on this issue. I'm Amadikwa Joy N. an outreachy applicant

@rowasc
Copy link
Contributor

rowasc commented Oct 20, 2020

@AishaSaman @amycruz97 you already have a ticket assigned. Let us know (in the corresponding ticket) if you are blocked. Thanks.
@bukolabisuga please go ahead with this one. Good luck.

@rowasc rowasc added this to the Hacktoberfest milestone Oct 20, 2020
@bukolabisuga
Copy link

Thanks so much @rowasc , I've raised a PR for this issue here : ushahidi/platform-client#1593

@ghost
Copy link

ghost commented Oct 20, 2020

Thanks so much @rowasc , I've raised a PR for this issue here : ushahidi/platform-client#1593

This woman ehn😂😂😂

@rowasc
Copy link
Contributor

rowasc commented Oct 20, 2020

@karenefereyan I have no idea what you intend with this comment, can you explain?
Thanks!

@ghost
Copy link

ghost commented Oct 21, 2020

@karenefereyan I have no idea what you intend with this comment, can you explain?
Thanks!

She sent in the PR minutes after she was assigned. It was so fast. That's what i mean

@tuxpiper
Copy link
Member

@all-contributors please add @bukolabisuga for code

@allcontributors
Copy link
Contributor

@tuxpiper

I've put up a pull request to add @bukolabisuga! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment