Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Only load d3 on demand #4928

Closed
tuxpiper opened this issue Apr 26, 2024 — with Linear · 1 comment
Closed

Performance: Only load d3 on demand #4928

tuxpiper opened this issue Apr 26, 2024 — with Linear · 1 comment
Labels
Codebase: Client Indicates issue work will be in client Tech Debt Theme: Page load ...

Comments

Copy link
Member

D3 is big.. don't include it in bundle.js.
Just load on demand as needed.

Created by @rjmackay on 2015-07-21 12:22:50.

_Imported from https://phabricator.ushahidi.com/T1726_

Aha! Link: https://ushahiditeam.aha.io/features/PROD-745

View original issue in GitHub


rjmackay 2015-09-23

@vbhv are you already on to this? Just making sure I don't double up work

hollycorbett 2015-09-23

I have a dumb question - would it make sense to do some kind of custom build of d3 for only what we need? It covers lots of stuff, and I've been poking it out of curiosity for the last month or two... I feel like what we use it for is pretty specific... but again, I'm no d3 wizard.. so this is just an idea :)

rjmackay 2015-09-23

probably.. I looked into it a while back, the build system is a bit complicated so might leave custom builds till after launch.

hollycorbett 2015-09-23

:) indeed

vbhv 2015-09-23

@rjmackay Yes working on it. I've got d3 loading. working on getting dc to load because it also requires a CSS. Will let you know how that goes.

jshorland 2017-08-29

@rjmackay should we keep this?

rjmackay 2017-08-30

I think so. This is still fairly relevant... unless activity page is going away, or being replaced

tuxpiper 2021-06-10

@Angamanga I think we will close this one soon :) Proposing to add to the ongoing project board.

@tuxpiper tuxpiper added Codebase: Client Indicates issue work will be in client Tech Debt Theme: Page load ... labels Apr 26, 2024 — with Linear
Copy link

linear bot commented Apr 26, 2024

@tuxpiper tuxpiper closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codebase: Client Indicates issue work will be in client Tech Debt Theme: Page load ...
Projects
None yet
Development

No branches or pull requests

1 participant