Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text-decoration: underline を指定してリンク文字列の存在を明確にしたい #15

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

yamanoku
Copy link
Contributor

@yamanoku yamanoku commented Apr 8, 2023

text-decoration: none text-decoration: underline
text-decoration: noneを指定したままのリンク文字列 text-decoration: underlineを指定した状態のリンク文字列

URL がリンクになっている場合となってない場合があったので、リンク文字列の場合は存在を明確にしておきたい

@vercel
Copy link

vercel bot commented Apr 8, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @ushironoko on Vercel.

@ushironoko first needs to authorize it.

@yamanoku yamanoku marked this pull request as ready for review April 9, 2023 10:04
@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 3:07pm

@ushironoko
Copy link
Owner

@yamanoku
ダークモードで破線にしてるのでライトモードもそうしたいかもです
スクリーンショット 2023-04-14 12 39 34

@yamanoku
Copy link
Contributor Author

@ushironoko border-color の方で修正しました
Screen Shot 2023-04-15 at 0 00 51

Copy link
Owner

@ushironoko ushironoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ushironoko ushironoko merged commit 76a70e8 into ushironoko:master Apr 14, 2023
@yamanoku yamanoku deleted the feat-link-text-decoration branch April 14, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants