Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing resuming with uploadid #100

Merged
merged 1 commit into from
Nov 9, 2012
Merged

Conversation

stigger
Copy link
Contributor

@stigger stigger commented Nov 5, 2012

Amazon returns inclusive byte ranges, so in order to resume to work correctly we need to increase the "stop" variable, otherwise hashes don't match and worker.uploaded_size has incorrect value.

Amazon returns inclusive byte ranges, so in order to resume to work correctly we need to increase the "stop" variable, otherwise hashes don't match and worker.uploaded_size has incorrect value.
@uskudnik
Copy link
Owner

uskudnik commented Nov 9, 2012

Can't test ATM, but looks reasonable since we do things like [start:stop] and for python that means stop-1.

uskudnik added a commit that referenced this pull request Nov 9, 2012
Fixing resuming with uploadid
@uskudnik uskudnik merged commit 9760df5 into uskudnik:master Nov 9, 2012
@uskudnik
Copy link
Owner

uskudnik commented Nov 9, 2012

Hmm... looking a bit more thoroughly - are you sure this is OK for .read(stop-start) and similar calls? Maybe we should just change https://github.com/stigger/amazon-glacier-cmd-interface/blob/c1c253fc0a9384adfea052f6733144848dc83cbc/glacier/GlacierWrapper.py#L1019 to [start:stop+1] ?

@stigger
Copy link
Contributor Author

stigger commented Nov 9, 2012

I'm sure. I've uploaded 100 gigabytes of data in ~20 files, works correctly.

@offlinehacker
Copy link
Contributor

I am rewriting upload funcionalty, it will work.
On Nov 9, 2012 7:09 PM, "Vyacheslav Karpukhin" notifications@github.com
wrote:

I'm sure. I've uploaded 100 gigabytes of data in ~20 files, works
correctly.


Reply to this email directly or view it on GitHubhttps://github.com//pull/100#issuecomment-10238795.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants