Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tendrl setup #6

Merged
merged 86 commits into from
Dec 20, 2016
Merged

Tendrl setup #6

merged 86 commits into from
Dec 20, 2016

Conversation

fbalak
Copy link
Contributor

@fbalak fbalak commented Nov 29, 2016

All changes from all other branches of mine, previous branches are deprecated. The pull request is opened for sake of a review.

fbalak and others added 30 commits November 29, 2016 16:00
…ittle code, changed default variable value of tendrl_gluster_bridge_repo_branch
@mbukatov
Copy link
Contributor

I'm going through the last step: installation of tendrl-api.

tendrl-devel role should be included automatically based on metadata
dependencies of any role which would require devel tools to be installed
during installation from source code
Default `exclude_groups` value was wrong, the default should follow
suggestion for "production setup only" exalty as documented in README[1]
file, which states:

> [tendrl-api] $ bundle install --path vendor/bundle --binstubs vendor/bin \
>               --without development test documentation

[1] https://github.com/Tendrl/tendrl-api/blob/74db59b7cfb7ac1a1df20cfcda948c33a67061d8/README.adoc
This is initial version of suggested workaround for:
Tendrl/api#41
Previous code was not idempotent (multiple runs would corrupt the
etcd.yml file) and this commit fixes that problem.
based on Tendrl/api#25

Epel repository is enabled for tendrl-api role only, in clear and
explicit way.
@mbukatov
Copy link
Contributor

Ops, my idea (based on ansible docs, see [1]) about setting enablerepo=None doesn't work, when I do that, I get:

FAILED! => {"changed": false, "failed": true, "msg": "Error setting/accessing repos: Error getting repository data for None, repository not found"}

[1] ansible docs for yum module states:

  • enablerepo
    `Repoid' of repositories to enable for the install/update operation. These repos will not persist beyond
    the transaction. When specifying multiple repos, separate them with a ",".
    [Default: None]

From now on, roles doesn't care about epel (or any other repositories)
at all. One needs to enable epel by adding epel role into ap playbook
and then list tendrl roles.
@mbukatov
Copy link
Contributor

@mkudlej could you review the current state again? I don't expect major changes at this point.

Copy link
Contributor

@mkudlej mkudlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems OK to me. I haven't tested if code is working.

@mbukatov
Copy link
Contributor

mbukatov commented Dec 20, 2016

Source installation needs a little tweak:

# curl http://localhost/api/1.0/Flows
<h1>Internal Server Error</h1>

Update: Since this may actually be a bug in tendrl-api (see Tendrl/api#31), it's not blocking merge of the pull request.

Since it's not clear how to setup etcd in clustered mode, it's not
necessary to install it like this, even though it's stated in the
installation.rst file.

Related to Tendrl/node-agent#88
@mbukatov
Copy link
Contributor

Ok, let's merge it to a master. There are many open questions about particular configuration details, or known issues on the tendrl side, so that the Tendrl installed via tendrl_gluster.yml playbook would not work (either tendrl-api, tendrl-node-agent or both are crashing), but from the ansible setup point of view, the setup is fine.

@mbukatov mbukatov merged commit ceb7b24 into master Dec 20, 2016
@mbukatov mbukatov deleted the tendrl-setup branch December 20, 2016 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants