Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import cluster framework plus test #31

Merged
merged 6 commits into from
Feb 9, 2017
Merged

Conversation

ltrilety
Copy link
Contributor

@ltrilety ltrilety commented Feb 2, 2017

First shot for import cluster test

Copy link
Contributor

@mkudlej mkudlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this pull request to reflect that is contains "import cluster" test too.

"""
Row in Cluster table model.
"""
# TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this part can be uncommented? Could you please add here any link to issue, specification, jira?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this particular part can be uncommented a lot.
When I started with the test it was not ready, but now it's in better condition. However for the test it's not required, hence I left it.
I'll put here some comment with specification Tendrl/specifications#82

"""
# TODO: support other options
self.start_import_cluster_wizard()
# TODO: close the warning dialogue about unaccepted hosts if needed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this can be uncommented? Could you please add here link to any issue, specification, design document, jira?

_model = m_cluster_list.ClusterRowModel
_required_elems = []

# Coming soon...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented and when can it be uncommented? Could you please add link to issue, specification, design document?

by default all host are selected with default roles
"""
# TODO: support other options
self.start_import_cluster_wizard()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is next page after this one?

Copy link
Contributor Author

@ltrilety ltrilety Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a page with a link for the import cluster task. I put here some TODO, for the first test it's not important at all as the import is not started from this point.

"""
Page model for dashboard
"""
# Coming soon...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing TODO and link to related issue, design document, jira, specification.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In truth I should not put here dashboard at all, as it's not part of latest build.
Not sure which issue probably Tendrl/ui#120 I'll put it to the start of the models.py file

_label = 'main page - menu bar'
_required_elems = [
# left part of upper navbar
# Coming soon...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When? Please add related links to be able to track it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no links yet

'nodes_link'
]

# def open_dashboard(self, click_only=False):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this code commented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because dashboard is not available for now


import pytest

# Coming soon ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When? Please add related links to be able to track it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that the default user is already logged in
for the test to work should extend this class.
"""
# NOTE: For now it just solves the landing page - no log in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add TODO too.

import_cluster_page.import_click()
# TODO: Wait till the cluster is imported, check task
# When finished, remove following line(s)
import time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file ticket to usmqe-test to be able to track this nad add link here.

@ltrilety ltrilety changed the title framework for import cluster import cluster framework plus test Feb 3, 2017
@ltrilety ltrilety requested a review from mkudlej February 6, 2017 15:08
Copy link
Contributor

@mkudlej mkudlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ltrilety ltrilety merged commit bf6b373 into usmqe:master Feb 9, 2017
@ltrilety ltrilety deleted the import_test branch February 10, 2017 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants