Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cachebusters should change between passes #13

Open
malerichc opened this issue Apr 10, 2018 · 1 comment
Open

Cachebusters should change between passes #13

malerichc opened this issue Apr 10, 2018 · 1 comment

Comments

@malerichc
Copy link
Contributor

There is a command-line option that allows for doing multiple "passes", so that any directives that fail in one pass will be re-tested in the next pass. There is a bug with this currently where if cachebusting is enabled, the cachebuster does not change between passes, but it should.

@mcbridem
Copy link
Contributor

It has long been my suspicion that part of the reason --passes=2 was generally successful was due to this accidental (mis)feature. In my mind, this issue dovetails with #16. For particularly expensive URLs such as XML sitemaps, whether those URLs are serving the content and the appropriate status code is probably more important than whether they're being freshly generated by the origin. If this issue is resolved and we more aggressively cache-bust between passes, maybe these more expensive URLs could be marked as not to be cache-busted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants