Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomwise work #60

Merged
merged 4 commits into from Apr 7, 2022
Merged

Atomwise work #60

merged 4 commits into from Apr 7, 2022

Conversation

bdecost
Copy link
Collaborator

@bdecost bdecost commented Apr 7, 2022

checking through atomwise training loop and force computation

I think we should probably consolidate around the idea of storing target tensors and output tensors in dictionaries. then we can generate a custom loss function and go back to using ignite, and hopefully remove some of the code complexity

@bdecost bdecost requested a review from knc6 April 7, 2022 17:53
@codecov-commenter
Copy link

Codecov Report

Merging #60 (28da4e0) into atomwise (241dcab) will decrease coverage by 0.02%.
The diff coverage is 38.46%.

@@             Coverage Diff              @@
##           atomwise      #60      +/-   ##
============================================
- Coverage     70.56%   70.54%   -0.03%     
============================================
  Files            19       19              
  Lines          2402     2400       -2     
============================================
- Hits           1695     1693       -2     
  Misses          707      707              
Impacted Files Coverage Δ
alignn/models/alignn_atomwise.py 30.40% <12.50%> (+0.60%) ⬆️
alignn/train.py 59.66% <56.52%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241dcab...28da4e0. Read the comment docs.

@knc6 knc6 merged commit 53976e3 into atomwise Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants