New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second RC constant in stepResponseAnalysis can be negative #48
Comments
I've modified stepResponseAnalysis.py to mark these events as invalid and put a pull request in to merge this fix. When you get a chance, let me know if it works. |
Can you upload a small snippet of the file or a database that contains the event time-series? It would be useful to debug the cause of the negative RC constants. |
DB and settings can be found here: https://www.dropbox.com/sh/zx3aiv5n8wbteny/AADV11dJmx9zHq0alB4uXqnca?dl=0 There are also a few negative residence times in that one. MOSAIC had a very hard time with that data set, which was odd for a number of reasons, so I am not sure that MOSAIC's model is appropriate for it to begin with. |
It appears that most of the events have extremely shallow blockades (i/i_0>0.95). It may just be that this is a pathological data set that may not be suited for MOSAIC as you alluded to previously. You could also try to link the RC constants. Just set "UnlinkRCConst" to 0 in the settings for stepResponse to see if that helps. |
Yea, I don't think failure here points to any weakness inherent to MOSAIC, though unphysical time values need to be addressed somehow - the solution presented already is likely all that is needed to address the issue. |
Since the relaxation that RC constants need not be equal in stepResponseAnalysis, a file I recently analyzed (available on request) had several events with negative RC constant for the second one but reported normal processing status.
The text was updated successfully, but these errors were encountered: