Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erf and tgamma function #3

Closed
jxo opened this issue Jul 18, 2019 · 1 comment
Closed

erf and tgamma function #3

jxo opened this issue Jul 18, 2019 · 1 comment

Comments

@jxo
Copy link

jxo commented Jul 18, 2019

erf and tgamma function is not found
sizedistribution.cpp, line63, no tgamma
line 86,88 no erf.
my compiler is vs2010, maybe these are contained in newer compilers.

and in torrspar.cpp, line 143
this erf conditional function is not right while xx ==1

and why we need unit_sdf in facet.cpp, line 22, this line will cause init problem.

@thomas-germer
Copy link
Member

You should remove the functions erf and erfc in torrspar.cpp. The functions erf, erfc, and tgamma are defined in the C99 standard.

The definition of unit_sdf shouldn't cause init problems, but it is not needed. It is a relic of an old version. It will be removed.

These changes will soon be pushed to github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants