Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change link styling to be more visible / underline on hover? #618

Closed
NickleDave opened this issue Dec 7, 2021 · 2 comments
Closed

change link styling to be more visible / underline on hover? #618

NickleDave opened this issue Dec 7, 2021 · 2 comments

Comments

@NickleDave
Copy link
Contributor

Maybe this is my mild color-blindness talking, but I just noticed that hyperlinks are not super visible in the site theme?e.g. here, I only see the links to Jeff and Pat if I stare at them because I know they're there
https://us-rse.org/events/2021/2021-12-community-call/

(copying text from Slack discussion)

@mtbc gave a 👍 for raising an issue

@cmaimone added:

They were blue before, I think, which stood out in a bad way -- too visible. We made them the default pink, but it is fairly subtle compared to the text color. They should underline on hover. Alternatives are welcome -- there are several places in the css that need to be changed. Probably best to search for the hex for the pink to find relevant places (but there are other things that use the same pink, so check that it's an actual link setting!)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

Welcome to us-rse! We are excited that this is your first issue!

@NickleDave
Copy link
Contributor Author

NickleDave commented Oct 1, 2022

I am looking at this some more since I am still noticing that links are hard to find (for me at least, could be my partial color-blindness).

I found these accessibility guidelines discussing how body text relates to links:
https://webaim.org/resources/linkcontrastchecker/

For usability and accessibility, links should be underlined by default. Otherwise, link text must have at least 3:1 contrast with surrounding body text, and must present a non-color indicator (typically underline) on mouse hover and keyboard focus.

We already present underline on hover
(I think here?)

}@media (max-width: 63.9375em) {

But I think it is not the case that our link and surrounding text have 3:1 contrast
https://contrast-ratio.com/#%233d4144-on-%23741755
image

I used this tool that suggested using #f18dc7 for links instead to contrast with our text color
https://www.learnui.design/tools/accessible-color-generator.html

image

If I try that color pairing with the previous tool, it does increase the contrast (I can actually read the text on the page!)

image

NickleDave added a commit to NickleDave/usrse.github.io that referenced this issue Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant