Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use your implementation, and ended up having to make a few tweaks in order to get the code to work again when I'm not supplying
attn_mask
, which should be a valid mode.Even when I did try to supply
attn_mask
, I ran into some problems where using+=
was breaking broadcasting rules (implicit with theattn_mask.unsqueeze(0)
call for batch), and also needed theto get the
attn
tensor into the expected format.