Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert for the application’s status endpoint. #650

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

adunkman
Copy link
Contributor

Closes #250.

This asserts that all checks returned by the system health endpoint return successfully.

Note:

  • This PR removes the ClamAV status check from the API, as it is hardcoded to return false (thus failing the alert). However, I’ve left the UI implementation of the ClamAV security check, so it still shows failing in the UI at https://stg.ef-cms.ustaxcourt.gov/health.

This causes our health check to fail, as it is rightfully checking that
ClamAV is available (because it is not implemented).
Copy link
Collaborator

@mmarcotte mmarcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the warning
alarm bells

@mmarcotte mmarcotte merged commit 44b7396 into staging Dec 14, 2020
@mmarcotte mmarcotte deleted the add-alert-for-status-endpoint branch December 14, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure health monitoring alerts
2 participants