[Unsolved issue] Large medicare wages leads to incorrect additional medicare tax

[zakpatterson]

This is not a PR, it's an issue! - Someone wanting to assist may add github.com/zakpatterson as a remote and submit a PR there based on the fix-intermittent-fica-test-failure branch. Feel free to open a new PR here too though.

It appears that if medicare wages and medicare withholding are allowed to get very large, medicare tax amounts become incorrect.

Info causing fail. Note, it seems that medicare income is greater than income in a w2. That's possible right?

  {
    f1099s: [],
    w2s: [
      {
        occupation: '',
        income: 4936065,
        medicareIncome: 4246324,
      },
      {
        occupation: '',
        income: 9517878,
        medicareIncome: 8650774,
      },
      {
        occupation: '',
        income: 7016062,
        medicareIncome: 9947902,
        personRole: 'PRIMARY',
        ssWages: 0,
        ssWithholding: 0,
        medicareWithholding: 331253,
        state: 'AL',
        stateWages: 0,
        stateWithholding: 0,
        box12: {}
      }
    ],
    realEstate: [],
    estimatedTaxes: [],
    f1098es: [],
    f3921s: [],
    scheduleK1Form1065s: [],
    itemizedDeductions: {},
    taxPayer: {
      filingStatus: 'S',
      primaryPerson: {
        firstName: '',
        lastName: '',
        ssid: '000000000',
        role: 'PRIMARY',
        address: {
          address: '0 ',
          aptNo: '0',
          city: '',
          state: 'AL',
          zip: '000000000'
        },
        isTaxpayerDependent: false
      },
      spouse: undefined,
      dependents: [],
      contactEmail: '@.',
      contactPhoneNumber: '0000000000'
    },
    questions: {},
    stateResidencies: [{ state: 'AL' }],
    healthSavingsAccounts: [],
    credits: [],
    individualRetirementArrangements: []
  },
  []
]

test output

 FAIL  src/forms/Y2020/tests/fica.test.ts
  fica
    ✓ should give refund SS tax overpayment only in some conditions (431 ms)
    ✓ should give SS refund based on filing status (348 ms)
    ✓ should not give a refund if each person has less than the max (315 ms)
    ✓ should give a refund if a person has more than the max if they have two w2s (320 ms)
    ✓ should add Additional Medicare Tax form 8959 (289 ms)
    ✕ should add Additional Medicare Tax based on filing status (721 ms)

  ● fica › should add Additional Medicare Tax based on filing status

    Property failed after 1 tests
    { seed: 307263146, path: "32:0:25:1:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:24:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:50:98:75:75:77:75:77:75:78:75:75:75:79:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76:76", endOnFailure: true }
    Shrunk 0 time(s)
    Got error: Error: expect(received).toBeUndefined()

    Received: 1

    Stack trace: Error: expect(received).toBeUndefined()

    Received: 1

      241 |           )
      242 |         } else {
    > 243 |           expect(displayRound(f1040.l25c())).toBeUndefined()
          |                                              ^
      244 |         }
      245 |       }
      246 |     }, failParams)

What kind of change does this PR introduce? (delete not applicable)

• Bugfix

[zakpatterson]

After fixing test, remove this special case