Support multiple tax years in UI, move forms to ustaxes-forms #662

zakpatterson · 2021-10-19T16:17:06Z

What kind of change does this PR introduce?

Feature

A redo of #566

Forms are now contained in ustaxes-forms. Tax years will be modeled using separate branches of that repo, and each branch will be added here as a git submodule.

Added scripts to set up submodules for 2020 and 2021.

Added the UI to enable building 2021 returns.

Data models and validations have been moved to ustaxes-core. So our structure now is:

             ustaxes-core
   /                 |       \
ustaxes-forms-2020   |     ustaxes-forms-2021
  \     (forms are single repo, multi branch)
   \                 |      / 
    \                |     / 
                ustaxes

Note: Setting up this structure did require updating NPM. This does not work on NPM 6. npm ci will also fail for users running npm6, and there is no way to warn them, since ci doesn't run any of the preinstall/prepare tasks before updating node_modules. We display an error in front of start or test.

About complexity, of course this adds a ton. If a user needs to add a new piece of UI for a new piece of user data, and update the data model, and update a tax form with that new piece of data, that will be three pull requests. On the other hand, UI PRs can't make updates to the data model or tax forms, and can't break tests in those projects. So it ...is also good? Perhaps time will tell.

codecov-commenter · 2021-10-20T09:43:10Z

Codecov Report

Merging #662 (e25de85) into master (739d563) will decrease coverage by 15.31%.
The diff coverage is 60.53%.

@@             Coverage Diff             @@
##           master     #662       +/-   ##
===========================================
- Coverage   71.16%   55.85%   -15.32%     
===========================================
  Files         116       66       -50     
  Lines        3815     1443     -2372     
  Branches      595      320      -275     
===========================================
- Hits         2715      806     -1909     
+ Misses       1086      624      -462     
+ Partials       14       13        -1

Impacted Files	Coverage Δ
src/components/DataPropagator.tsx	`0.00% <0.00%> (ø)`
src/components/Main.tsx	`0.00% <0.00%> (ø)`
src/components/Menu.tsx	`93.33% <ø> (-0.42%)`	⬇️
src/components/Patterns.ts	`87.50% <0.00%> (-6.25%)`	⬇️
src/components/SaveToFile.tsx	`0.00% <0.00%> (ø)`
src/components/Summary.tsx	`45.16% <ø> (+35.48%)`	⬆️
src/components/TaxPayer/PersonFields.tsx	`25.00% <0.00%> (ø)`
src/components/debug.tsx	`0.00% <0.00%> (ø)`
src/components/deductions/F1098eInfo.tsx	`16.00% <ø> (ø)`
src/components/income/F1099Info.tsx	`56.17% <ø> (ø)`
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739d563...e25de85. Read the comment docs.

Add tests for year selector

thegrims

Has the same error as before of error messages for bad input not showing up on some pages, like the first page

zakpatterson · 2021-10-26T09:10:59Z

    expect(received).not.toHaveLength(expected)

    Expected length: not 0
    Received array:      []

    Ignored nodes: comments, <script />, <style />

Checking out 9b62cff should show the above failed test, where the Save button is pressed and the component rerenders and resets the data without letting the errors display.

for year selector

thegrims · 2021-10-29T18:28:10Z

Comment has been resolved by Aidan Grimshaw

Filing status should throw an error and not allow progression to the next page until it is filled out

Browser metadata

Path:      /spouseanddependent
Browser:   Chrome 95.0.4638.54 on Windows 10
Viewport:  1536 x 754 @1.25x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Unresolved

thegrims · 2021-10-29T18:32:12Z

State wages seems to sometimes throw an error when not filled out, sometimes not

Browser metadata

Path:      /income/w2jobinfo
Browser:   Chrome 95.0.4638.54 on Windows 10
Viewport:  1536 x 754 @1.25x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

netlify · 2021-10-30T00:29:50Z

Comment has been resolved by Aidan Grimshaw

A reviewer left a comment:

I tried a ton of times and I was eventually successful in getting the form to pass without that field filled, but I think what is happening is the field was populated with "Single", which is then disallowed by the addition of a spouse. The form field removes the corresponding <option> tag so the field shows as empty, but in the form state it is still set to single.

So you should be able to see this on master now.

Browser metadata

Path:      /income/w2jobinfo
Browser:   Firefox 93.0 on Ubuntu 
Viewport:  3072 x 1080 @1.25x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Unresolved

# Conflicts: # package-lock.json # src/components/Questions.tsx # src/components/RefundBankAccount.tsx # src/components/TaxPayer/TaxPayer.tsx # src/components/income/RealEstate.tsx # src/components/income/W2JobInfo.tsx # src/tests/components/Taxpayer.test.tsx

zakpatterson · 2021-12-15T14:08:35Z

I've finally convinced myself this strategy is a bad one. See #778

zakpatterson · 2021-12-20T14:45:02Z

This is replaced by #778

zakpatterson marked this pull request as draft October 19, 2021 16:17

Support multiple tax years

cc0d5c6

zakpatterson force-pushed the feature-years-working branch from 0a61ee6 to cc0d5c6 Compare October 20, 2021 09:43

zakpatterson marked this pull request as ready for review October 20, 2021 09:43

zakpatterson marked this pull request as draft October 20, 2021 12:42

zakpatterson added 3 commits October 23, 2021 23:07

Trying to fix not-found error

4f89a95

Add tests for year selector

Merge branch 'master' into feature-years-working

96cbdcc

Fix data types in tests

736baaa

zakpatterson marked this pull request as ready for review October 24, 2021 10:39

thegrims requested changes Oct 24, 2021

View reviewed changes

zakpatterson marked this pull request as draft October 25, 2021 13:05

zakpatterson force-pushed the feature-years-working branch 2 times, most recently from 6627f99 to 55c75de Compare October 26, 2021 06:17

zakpatterson force-pushed the feature-years-working branch 3 times, most recently from 92b0e53 to b36100e Compare October 26, 2021 13:03

zakpatterson added 2 commits October 29, 2021 09:59

Make taxpayer test reusable, add regression test

9b62cff

for year selector

Fix form update error state issues

f3b9061

zakpatterson force-pushed the feature-years-working branch from b36100e to 77f205e Compare October 29, 2021 01:06

zakpatterson marked this pull request as ready for review October 29, 2021 02:06

zakpatterson force-pushed the feature-years-working branch from 77f205e to dec5749 Compare October 29, 2021 10:04

Merge branch 'master' into feature-years-working

593b3cd

zakpatterson force-pushed the feature-years-working branch from 7e1d195 to 593b3cd Compare October 29, 2021 10:12

Merge branch 'master' into feature-years-working

3475f3f

ustaxes deleted a comment from netlify bot Oct 30, 2021

zakpatterson added 3 commits December 9, 2021 18:42

Update submodule

2d39a61

Calm down codecov

f2b6541

Try explicit pulling submodules

b59f41e

zakpatterson force-pushed the feature-years-working branch from 8b4b326 to b59f41e Compare December 9, 2021 10:01

Fix root dir eslint

9a60faf

zakpatterson force-pushed the feature-years-working branch from 07f5995 to 9a60faf Compare December 9, 2021 10:05

zakpatterson added 2 commits December 9, 2021 19:20

Simplify netlify build

587407b

Update docs about npm

0c8cf05

zakpatterson marked this pull request as ready for review December 9, 2021 11:01

zakpatterson marked this pull request as draft December 9, 2021 11:49

zakpatterson added 5 commits December 10, 2021 10:22

Add version block for npm

ff3e27e

Fix Prompt inside router merge error

e186d58

Npm 7 should be ok (for netlify.)

045d7b6

Fix sub branch links

e86aea9

Add submodule update merge and checkout notes

f8ac587

zakpatterson force-pushed the feature-years-working branch from 4d85f44 to f8ac587 Compare December 10, 2021 02:55

zakpatterson marked this pull request as ready for review December 10, 2021 03:02

zakpatterson marked this pull request as draft December 10, 2021 03:07

zakpatterson added 3 commits December 13, 2021 01:12

Fix lint and stop react-scripts from hiding logs

e7a1009

Refactor year-splitting logic into a single class

7d4f5cb

Update submodules

3e9ad73

zakpatterson marked this pull request as ready for review December 12, 2021 16:54

zakpatterson added 2 commits December 13, 2021 02:00

Remove double run of setup script for netlify

2e70c13

Update submodule pointer references

e25de85

zakpatterson force-pushed the feature-years-working branch from 5bb5ee5 to e25de85 Compare December 13, 2021 15:14

zakpatterson mentioned this pull request Dec 15, 2021

Support multiple years #778

Merged

zakpatterson closed this Dec 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support multiple tax years in UI, move forms to ustaxes-forms #662

Support multiple tax years in UI, move forms to ustaxes-forms #662

zakpatterson commented Oct 19, 2021 •

edited

Loading

codecov-commenter commented Oct 20, 2021 •

edited by codecov bot

Loading

thegrims left a comment

zakpatterson commented Oct 26, 2021 •

edited

Loading

thegrims commented Oct 29, 2021 •

edited

Loading

thegrims commented Oct 29, 2021

netlify bot commented Oct 30, 2021 •

edited

Loading

zakpatterson commented Dec 15, 2021

zakpatterson commented Dec 20, 2021

Support multiple tax years in UI, move forms to ustaxes-forms #662

Support multiple tax years in UI, move forms to ustaxes-forms #662

Conversation

zakpatterson commented Oct 19, 2021 • edited Loading

codecov-commenter commented Oct 20, 2021 • edited by codecov bot Loading

Codecov Report

thegrims left a comment

Choose a reason for hiding this comment

zakpatterson commented Oct 26, 2021 • edited Loading

thegrims commented Oct 29, 2021 • edited Loading

thegrims commented Oct 29, 2021

netlify bot commented Oct 30, 2021 • edited Loading

zakpatterson commented Dec 15, 2021

zakpatterson commented Dec 20, 2021

zakpatterson commented Oct 19, 2021 •

edited

Loading

codecov-commenter commented Oct 20, 2021 •

edited by codecov bot

Loading

zakpatterson commented Oct 26, 2021 •

edited

Loading

thegrims commented Oct 29, 2021 •

edited

Loading

netlify bot commented Oct 30, 2021 •

edited

Loading