Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle minor dependency updates separately from major #790

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

zakpatterson
Copy link
Collaborator

@zakpatterson zakpatterson commented Dec 18, 2021

Dependabot tried to update eslint 7-8, react 16-17, react-router 5-6, react-scripts 4-5, and all of these are not working together or not working with some of our other dependencies (see #786, #789). This splits out the working minor version updates.

Also, the dependabot config is updated so minor version updates should go to dependabot-updates as usual, but major version updates go to a different branch dependabot-updates-major.

@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #790 (a26b60b) into master (1668ddc) will increase coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   69.96%   70.89%   +0.93%     
==========================================
  Files         116      116              
  Lines        3815     3835      +20     
  Branches      595      615      +20     
==========================================
+ Hits         2669     2719      +50     
+ Misses       1132     1102      -30     
  Partials       14       14              
Impacted Files Coverage Δ
src/irsForms/worksheets/ChildTaxCreditWorksheet.ts 97.67% <0.00%> (-2.33%) ⬇️
src/irsForms/ScheduleD.ts 95.00% <0.00%> (-0.96%) ⬇️
src/pdfFiller/pdfHandler.ts 30.00% <0.00%> (-0.77%) ⬇️
src/components/Summary.tsx 9.09% <0.00%> (-0.59%) ⬇️
src/components/createPDF.tsx 3.12% <0.00%> (-0.11%) ⬇️
src/serviceWorker.js 0.00% <0.00%> (ø)
src/pdfFiller/Fill.ts 100.00% <0.00%> (ø)
src/irsForms/worksheets/SocialSecurityBenefits.ts 0.00% <0.00%> (ø)
src/components/FormContainer.tsx 94.73% <0.00%> (+0.07%) ⬆️
src/tests/common/LocalForms.ts 93.33% <0.00%> (+0.47%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1668ddc...a26b60b. Read the comment docs.

@zakpatterson zakpatterson changed the title Add working part of dependabot updates Handle minor dependency updates separately from major Dec 18, 2021
@zakpatterson zakpatterson merged commit 9e5da90 into ustaxes:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant