Fix default ajv options, eslint react warning #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were seeing a warning in test: console.warn strict mode: use allowUnionTypes to allow union type keyword at "#/definitions/ItemizedDeductions/properties/medicalAndDental" (strictTypes) at checkStrictMode (node_modules/ajv/lib/compile/util.ts:212:18) at strictTypesError (node_modules/ajv/lib/compile/validate/index.ts:322:18) at checkMultipleTypes (node_modules/ajv/lib/compile/validate/index.ts:294:5) at checkStrictTypes (node_modules/ajv/lib/compile/validate/index.ts:274:33) at schemaKeywords (node_modules/ajv/lib/compile/validate/index.ts:231:18) at typeAndKeywords (node_modules/ajv/lib/compile/validate/index.ts:161:3) at subSchemaObjCode (node_modules/ajv/lib/compile/validate/index.ts:147:3) at subschemaCode (node_modules/ajv/lib/compile/validate/index.ts:124:7)
zakpatterson
force-pushed
the
fix-default-ajv-options
branch
from
9073e05
to
e8e615f
Compare
Codecov Report
@@ Coverage Diff @@
## master #961 +/- ##
==========================================
+ Coverage 53.23% 53.44% +0.21%
==========================================
Files 216 216
Lines 9864 9864
Branches 1365 1365
==========================================
+ Hits 5251 5272 +21
+ Misses 4599 4578 -21
Partials 14 14
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (delete not applicable)
At some point after an AJV update, we started seeing many console warnings like this one:
For example at this test run
There are a lot of ajv options that we could use. See this doc