[New Feature] need wheel's disabled option[#712] #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
补充动图，手机录视频转gif太大了 |
theniceangel
reviewed
Dec 6, 2018
| BScroll.prototype._checkWheelhasValidIndex = function () { | ||
| for (let i = 0; i < this.items.length; i++) { | ||
| if (this.items[i].className.indexOf('disabled') === -1) { |
There was a problem hiding this comment.
这里的 disabled 耦合严重，这里可以取一个配置项吧，参考下 wheels 配置的做法
There was a problem hiding this comment.
这里取的就是配置项，这里的items是元素，只能凭借其class进行判断
src/scroll/wheel.js
Outdated
|
|
||
| BScroll.prototype._getWheelValidIndex = function (y) { | ||
| let tempIndex = Math.round(-y / this.itemHeight) |
There was a problem hiding this comment.
这个函数的功能只是为了获取距离滚动方向相反最近的非 disabled 的 item 的索引吧，里面很多变量是多余的，当前对象上有属性可以判断滚动方向，逻辑写的太复杂了
|
@theniceangel |
|
你给出的 gif 图貌似也有bug，从巫妖怎么到撼地神牛了，按道理如果你下滑，应该是向上找第一个非 disabled 的 item吧 |
|
这里逻辑好像的确有问题，我当时考虑的是松手的时候就近找一个 |
|
@ustbhuangyi |
|
@dolymood |
|
@hezhongfeng 参考 iOS 原生的 disabled 的行为就可以了 |
2、优化_getWheelValidIndex函数
|
|
|
Thanks |
|
@theniceangel @dolymood 谢谢你们开源才好，等着合并到cube-ui的picker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[New Feature] need wheel's disabled option[#712]