Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Homebrew #189

Merged
merged 3 commits into from Oct 14, 2021
Merged

Update docs for Homebrew #189

merged 3 commits into from Oct 14, 2021

Conversation

XuehaiPan
Copy link
Contributor

@XuehaiPan XuehaiPan commented Oct 13, 2021

Update docs for Homebrew.

  • Update install instruction for Homebrew / Linuxbrew.
  • Add docs for environment variables HOMEBREW_BREW_GIT_REMOTE and HOMEBREW_CORE_GIT_REMOTE.

Copy link
Member

@taoky taoky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外这个 PR 太大了,最好能拆成两个 PR:一个只改 brew tap --custom-remote,另一个修改其他的部分。

source/brew.git.rst Outdated Show resolved Hide resolved
source/brew.git.rst Outdated Show resolved Hide resolved
source/brew.git.rst Outdated Show resolved Hide resolved

由于 brew 安装脚本此前多次修改相关的变量名,也可以参考以下命令,让 Git 将脚本访问的所有 GitHub 的 URL 替换为科大源:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insteadOf 替换的方式最好留着,我不想在 homebrew 再丢掉 HOMEBREW_CORE_GIT_REMOTE 之后再改帮助。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HOMEBREW_CORE_GIT_REMOTEbrew 的环境变量,与官方的 installer 无关。自 Homebrew/install#534 起,官方的 installer 支持安装时即从环境中读取该变量。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那提一下 unset insteadOf 的内容?有用户现在是这么设置的。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那提一下 unset insteadOf 的内容?有用户现在是这么设置的。

是指重置 Remote 时的命令?一般设置了镜像之后就不会考虑换回 GitHub 的源了吧。新文档前面没有提到 insteadOf 的事情,后面突然提到 unset insteadOf 会不会有点突兀。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那提一下 unset insteadOf 的内容?有用户现在是这么设置的。

是指重置 Remote 时的命令?一般设置了镜像之后就不会考虑换回 GitHub 的源了吧。新文档前面没有提到 insteadOf 的事情,后面突然提到 unset insteadOf 会不会有点突兀。

比如说出问题调试的时候可能会换到 GitHub。如果之前用 insteadOf 改了忘了的话还挺难调试的……

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

添加了一句提示信息。具体 usnet 命令因 set 时的情况不同(有无引号,有无 --global 参数等)会不一样,故没有添加。

@XuehaiPan
Copy link
Contributor Author

另外这个 PR 太大了,最好能拆成两个 PR:一个只改 brew tap --custom-remote,另一个修改其他的部分。

已拆分。

source/brew.git.rst Outdated Show resolved Hide resolved
@taoky
Copy link
Member

taoky commented Oct 13, 2021

(另外不需要每次 force push,merge 的时候会 squash。)

@taoky taoky merged commit 1f1bfe6 into ustclug:master Oct 14, 2021
github-actions bot pushed a commit that referenced this pull request Oct 14, 2021
Xuehai Pan: Update docs for Homebrew (#189)

* Update docs for Homebrew

* Extend title underline

* Add notes for git-config insteadOf
@XuehaiPan XuehaiPan deleted the brew-docs branch October 20, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants