Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with modals when using adblocker #420

Closed
matthewedwards12 opened this issue Feb 11, 2016 · 7 comments
Closed

Issue with modals when using adblocker #420

matthewedwards12 opened this issue Feb 11, 2016 · 7 comments

Comments

@matthewedwards12
Copy link
Contributor

matthewedwards12 commented Feb 11, 2016

No description provided.

@matthewedwards12
Copy link
Contributor Author

Pointed out on Twitter on 9th. Using Crystal on iOS means that the Mobile Nav crashes the site. Needs investigation...

@daaain
Copy link
Contributor

daaain commented Feb 11, 2016

We might have to bite the bullet and go for a no Javascript baseline functionality as discussed in #348.

For the mobile menu in particular we could have it on a separate page / URL or be always shown when JS is disabled.

@andydutch
Copy link
Collaborator

Could using a fixed nav in the footer, perhaps icon based, work? or a menu that disappears on scroll down but reappears on scroll up (like Facebook's native app).

Research first how others do it

@phil-linnell phil-linnell changed the title Mobile nav does not work when using adblocker Issue with modals when using adblocker Feb 29, 2016
@daaain
Copy link
Contributor

daaain commented Mar 10, 2016

@chriswatts91
Copy link
Contributor

chriswatts91 commented Aug 23, 2016

Looks to be an issue with the react-transition-manager library. Crystal looks to be blocking div.shown.
I've temporarily removed shown class from the modal as it doesn't seem to have been used and have opened an issue here: collingo/react-transition-manager#6

@andydutch
Copy link
Collaborator

@chriswatts91, can you make a pull request with the fix?

If he doesn't merge it, we can fork it.

@phil-linnell
Copy link
Contributor

Closed as reassigning to new issue tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants