Features/readme release branch #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnau
reviewed
Jul 13, 2017
Makefile
Outdated
| @@ -58,13 +58,13 @@ include tasks/*.mk | |||
| ############################################################################### | |||
|
|
|||
| ## Porcelain ################################################################## | |||
| install: network-create vault-create assets-create app-create sandbox-create diversity-create proxy-create | |||
| install: network-create vault-create assets-create app-create sandbox-create proxy-create | |||
There was a problem hiding this comment.
If you remove the diversity tasks from the normal flow, are you going to provide another task, say make diversity-install to be able to deploy updates on that?
tasks/release.mk
Outdated
| @@ -40,3 +41,6 @@ release-push-snapshot: | |||
| $(DOCKER) push $(app_image) | |||
| $(DOCKER) push $(assets_image) | |||
| $(DOCKER) push $(sandbox_image) | |||
|
|
|||
| ## Build new images with a tag name, e.g. VERSION=auto, then push to docker hub | |||
There was a problem hiding this comment.
It would be good to explain the use case for this task. Perhaps with an example situation?
arnau
approved these changes
Jul 13, 2017
phil-linnell
force-pushed
the
features/readme-release-branch
branch
from
48c4b8f
to
0819218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arnau Here is the added release-branch task.
Also, just note, I removed diversity image tasks from the capture-all porcelain tasks. I don't see it necessary to be a part of that install process. Seem ok to you?