Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Fix component pages from audit (Phase 2) #2162
USWDS-Site: Fix component pages from audit (Phase 2) #2162
Changes from 35 commits
a1d0f71
b617e74
9c8865b
931992f
9af346d
6e090bd
99459b4
ec39db4
1d68936
e33193f
f55e4c6
b73717c
f11342b
e7a5b9f
693b9f0
a9048f8
3f8cc0d
525c9b7
a93b439
43654be
1af64ed
26c92c4
06c6c55
53841a8
afe572d
fbd764b
70391d9
7a3388c
4c776b8
46e5a90
769ad3a
ceef908
0b567e0
16c7554
29e5c33
47eacd6
7cacf39
2591df0
190e3a6
1825a35
4745cac
a7e3b52
f4c3ed0
c142315
08ce1df
8f5bac8
3afcf63
fe79cc9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this note still needed? Wondering if it can be considered outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In practice, does the file-input component remove the drag instructions if implemented on these browsers?
If it's still a feature of the component, I feel we should leave it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if there is documentation on
usa-skipnav
that we can point users to.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea! Do we have any
usa-skipnav
documentation? I can't seem to find any.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced this section with the "Add context by labelling your nav element." section. We do not use the navigation role in our code, and it seems unnecessary since we are using the semantic
nav
element.Is there a reason we would want to redundantly declare the role? Should we keep this note in but specify it is only if you are not using the
nav
element?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking - is the bolded statement accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reflects what's shown in example:
Default header preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is almost 13 years old. Is it still accurate? Do we want to keep it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This article isn't much newer, but I like the reasoning here:
Footnotes
https://www.fastcompany.com/3016894/should-your-tag-be-your-logo#:~:text=The%20first%20heading%20on%20your,organize%20information%20and%20orient%20users. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm included to keep it because:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this because it didn't feel like header-specific content. Is there a better spot for this content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old link just redirects to their blog home page. I found a post from them about tree testing, but I am not sure if it applies. Should we remove this or find another link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep for now. Created a new issue to follow-up on this #2187.