USWDS-Site - Changelog: Update documentation and add entry for in-page nav custom content [USWDS#5387] #2190
Conversation
- Remove element column from properties table - Instead added a note about adding props to usa-in-page-nav
…nto al-changelog-5387
…nto al-changelog-5387
mejiaj
changed the title
There was a problem hiding this comment.
Minor suggestion added. Agree with @mahoneycm's comment about adding to guidance #2190 (comment).
|
@mahoneycm @mejiaj |
- Original update here was a mistake
| {% include settings-table-flex.html | ||
| content=page.implementation.initProps | ||
| cols="flex-2, flex-1, flex-2, flex-1" | ||
| cols="flex-2, flex-2, flex-1" | ||
| section="initialization properties" | ||
| %} |
There was a problem hiding this comment.
This table could use a header to keep it consistent with table below.
Example
There was a problem hiding this comment.
Header added in 02a75dc. I also adjusted the column width in this commit because adding a header caused the table to span the width of the content area, rather than being constrained to the width of the content list, and I wanted to give a little extra room to the description column.
Co-authored-by: James Mejia <james.mejia@gsa.gov>
|
Thanks @mejiaj. I've made the requested updates. Let me know if you need anything else. |
…nto al-changelog-5387
Summary
data-main-content-selector.Preview link
Problem statement
PR uswds/uswds#5387 added a new data attribute that should be added to the documentation.
Testing and review
In both the properties table and changelog, confirm: