Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site - Changelog: Add entry for in-page nav exclude hidden headers [USWDS#5393] #2197

Merged
merged 6 commits into from Aug 18, 2023
Merged

USWDS-Site - Changelog: Add entry for in-page nav exclude hidden headers [USWDS#5393] #2197

merged 6 commits into from Aug 18, 2023

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Jul 19, 2023 •
edited

Summary

Added changelog entries for uswds/uswds#5393

Related PR

Related to uswds/uswds#5393

Excluded hidden headers from the in-page navigation link list. Any header with a style of display:none or visibility:hidden will be excluded from the list of links in the component.

Preview link

Changelog entry

@amyleadem amyleadem changed the title Add changelog for #5393 USWDS-Site: Create changelog for #5393 Jul 19, 2023
@amyleadem amyleadem mentioned this pull request Jul 19, 2023
Merged
@amyleadem amyleadem changed the base branch from main to release-3.5.1 July 21, 2023 19:16
@amyleadem amyleadem marked this pull request as ready for review July 21, 2023 20:53
mahoneycm
mahoneycm approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mejiaj mejiaj mentioned this pull request Aug 7, 2023
Closed
@mejiaj mejiaj changed the title USWDS-Site: Create changelog for #5393 USWDS-Site - Changelog: Add entry for in-page nav exclude hidden headers [USWDS#5393] Aug 8, 2023
@mejiaj mejiaj requested a review from thisisdano August 8, 2023 16:29
@mejiaj mejiaj deleted the branch release-3.6.0 August 11, 2023 20:52
@mejiaj mejiaj closed this Aug 11, 2023
@mejiaj mejiaj mentioned this pull request Aug 11, 2023
Merged
@amyleadem amyleadem reopened this Aug 11, 2023
@amyleadem amyleadem changed the base branch from release-3.5.1 to release-3.6.0 August 11, 2023 21:14
@thisisdano thisisdano merged commit 42d8169 into release-3.6.0 Aug 18, 2023
4 of 8 checks passed
@thisisdano thisisdano deleted the al-changelog-5393-2 branch August 18, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejiaj mejiaj mejiaj approved these changes

@thisisdano thisisdano thisisdano approved these changes

@mahoneycm mahoneycm mahoneycm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amyleadem @mejiaj @thisisdano @mahoneycm