Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site - Changelog: Add entry for remove high-contrast disabled border from %block-input-styles [USWDS#5397] #2204

Merged
merged 6 commits into from
Aug 18, 2023
Merged

USWDS-Site - Changelog: Add entry for remove high-contrast disabled border from %block-input-styles [USWDS#5397] #2204

merged 6 commits into from
Aug 18, 2023

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Jul 20, 2023 •
edited by amyleadem
Loading

Summary

Add change log item for uswds/uswds#5397

Preview link

Form change log →

@mahoneycm mahoneycm mentioned this pull request Jul 20, 2023
Merged
2 tasks
amyleadem
amyleadem requested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions! Let me know if you have questions.

_data/changelogs/component-form.yml Outdated Show resolved Hide resolved
_data/changelogs/component-form.yml Outdated Show resolved Hide resolved
mahoneycm and others added 2 commits July 20, 2023 13:48
@mahoneycm @amyleadem
Update _data/changelogs/component-form.yml
9859d18 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm @amyleadem
Update _data/changelogs/component-form.yml
f154aaf 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm mahoneycm requested a review from amyleadem July 20, 2023 17:56
amyleadem
amyleadem requested changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more update after our team discussion yesterday. Can you update the version to 3.5.1 and update the base branch to release-3.5.1?

_data/changelogs/component-form.yml Outdated Show resolved Hide resolved
@mahoneycm @amyleadem
Corrected uswds version number
366c0ec 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm mahoneycm requested a review from amyleadem July 24, 2023 13:38
@mahoneycm
Copy link
Contributor Author

@amyleadem great catch! Committed your suggestion 👍

@amyleadem amyleadem changed the base branch from main to release-3.5.1 July 24, 2023 14:17
amyleadem
amyleadem approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Note: I updated the base branch on this PR from main to release-3.5.1 so we don't lose track of this.

@mejiaj mejiaj mentioned this pull request Aug 7, 2023
Closed
@mejiaj mejiaj changed the title USWDS - Site: Add change log item for input border color USWDS-Site - Changelog: Add entry for remove high-contrast disabled border from %block-input-styles [USWDS/USWDS#5397] Aug 8, 2023
@mejiaj mejiaj changed the title USWDS-Site - Changelog: Add entry for remove high-contrast disabled border from %block-input-styles [USWDS/USWDS#5397] USWDS-Site - Changelog: Add entry for remove high-contrast disabled border from %block-input-styles [USWDS#5397] Aug 8, 2023
@mejiaj mejiaj deleted the branch release-3.6.0 August 11, 2023 20:52
@mejiaj mejiaj closed this Aug 11, 2023
@mejiaj mejiaj mentioned this pull request Aug 11, 2023
Merged
@mahoneycm mahoneycm reopened this Aug 11, 2023
@mahoneycm mahoneycm changed the base branch from release-3.5.1 to release-3.6.0 August 11, 2023 21:12
@thisisdano thisisdano merged commit b7f55b6 into release-3.6.0 Aug 18, 2023
8 checks passed
@thisisdano thisisdano deleted the cm-hc-input-border-changelog branch August 18, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejiaj mejiaj mejiaj approved these changes

@thisisdano thisisdano thisisdano approved these changes

@amyleadem amyleadem amyleadem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mahoneycm @mejiaj @thisisdano @amyleadem