New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site - Changelog: In-page nav header selector [#5444] #2252
Conversation
Putting this in draft because I need to make additional edits to other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just flagging a potential visual quirk on the properties table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Wasn't able to view the final output due to the build failing for some reason, but the code matches the expected pattern and should output as expected 👍
Important
We should ensure build before final merge
Summary
Preview link
Problem statement
PR uswds/uswds#5444 added a new data attribute that should be added to the documentation.
Testing and review
In both the properties table and changelog, confirm: