New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site - Disabled color contrast changelog #2254
Conversation
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@amyleadem committed your suggestions! Thanks for the input! |
Looking at this again and I wonder if this should be moved either to the form page or to the individual component pages instead of the settings page. Previously, we have added disabled color update changelogs to the individual component pages, for example checkbox. I lean towards doing the same here. |
Ooh good point. I definitely agree it should be added to the form page. It was originally added to the settings page because the error would happen if users update the theme color settings, so I feel like we should also maintain it here. I was on the fence about adding it for every component with disabled styles because it wasn't necessarily component-specific, but ultimately I think it's better to have it than not. I'll work on getting these added! |
…olor-contrast-changelog
…isabled-color-contrast-changelog
Update 2/29/24After some more discussion with the team, we decided to keep the changelog on the settings and form pages but not each component page because it is specifically a settings change Noting that other disabled style changes may still need to be included in component pages moving forward. |
Summary
Changelog entry for uswds/uswds#5455
Preview link
Settings changelog →
Form changelog →