Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Remove video tutorials and add monthly calls #2345

Merged
merged 28 commits into from Nov 15, 2023

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Nov 3, 2023

Summary

  • Removed the outdated video tutorials page
  • Added a monthly calls page

Warning
We need to update the changelog date before merge.

Related issue

Closes #2333

Preview link

Problem statement

The video tutorials page is outdated and has broken content. We should remove this page and redirect the video tutorials page to a new monthly calls page.

Solution

Testing and review

  • Confirm that the video tutorials page has been removed and the url redirects to the monthly calls page
  • Confirm that the video tutorials page is removed from the side navigation
  • Confirm that the new monthly calls page exists and has appropriate, accurate content
  • Confirm that the new monthly calls page is added to the side navigation
  • Confirm that the on-page navigation works and reads as expected

@amyleadem amyleadem changed the title Al-monthly-call-page USWDS-Site: Remove video tutorials and add monthly calls Nov 6, 2023
@amyleadem
Copy link
Contributor Author

amyleadem commented Nov 6, 2023

@sarah-sch @mejiaj

Based on the recommendation in this comment, I embedded the playlist on the monthly calls page. I had a couple of questions:

- It looks like it defaults to show only the most recent video in the playlist, with an icon that opens a menu to show thumbnails of other playlist videos. I'm a bit concerned that users might not immediately understand that there are more videos in the playlist. Maybe we can add some copy that explains that there are more available with a link to the full playlist? We could also investigate digging into the YouTube API for other display options, but that increases the complexity quite a bit, and I'm not even sure what options we have there.
- Are we sure that this playlist will only ever have monthly calls on it?

No longer using the playlist - instead, showing a list of individual MCs

Copy link
Contributor

@sarah-sch sarah-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added two suggestions.

pages/about/monthly-calls.md Outdated Show resolved Hide resolved
pages/about/monthly-calls.md Show resolved Hide resolved
amyleadem and others added 2 commits November 6, 2023 10:25
Co-authored-by: Sarah Schroeder <109311838+sarah-sch@users.noreply.github.com>
Co-authored-by: Sarah Schroeder <109311838+sarah-sch@users.noreply.github.com>
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, page looks good

@amyleadem amyleadem marked this pull request as ready for review November 6, 2023 18:34
@amyleadem
Copy link
Contributor Author

amyleadem commented Nov 6, 2023

@sarah-sch I committed your suggestions. Will you take a look at the page preview and let me know if you want any changes?

Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some super minor suggestions but overall I love this!

Testing checklist

  • Confirm that the video tutorials page has been removed and the url redirects to the monthly calls page
  • Confirm that the video tutorials page is removed from the side navigation
  • Confirm that the new monthly calls page exists and has appropriate, accurate content
  • Confirm that the new monthly calls page is added to the side navigation
  • Confirm that the on-page navigation works and reads as expected
  • Changelog is added

_data/nav.yml Outdated Show resolved Hide resolved
pages/about/monthly-calls.md Show resolved Hide resolved
@sarah-sch
Copy link
Contributor

@amyleadem - sorry that I missed your request to review yesterday, but looks great!

Copy link
Contributor

@sarah-sch sarah-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@thisisdano
Copy link
Member

I don't think the playlist-only solution is best solution here. We have all these monthly calls, and all these different topics, but this makes it feel like there's only one.

We have a real opportunity here to help direct folks to a specific monthly call, and to get a sense of the breadth of their topics. The overhead of adding new videos from month to month is worth it if we can point folks to this page and make it useful for finding a specific monthly call on a topic that's useful to the vistor

@amyleadem
Copy link
Contributor Author

amyleadem commented Nov 14, 2023

@thisisdano No problem! We are working on including some more of the details that were in your spreadsheet now. I'll ping both you and @sarah-sch when it is ready.

Edit: That is, unless you are happy with it is in its current state!

@thisisdano
Copy link
Member

Oh cool. I added an example of how it might work with a couple of commits, but feel free to modify or just use your own solution

@amyleadem
Copy link
Contributor Author

amyleadem commented Nov 14, 2023

@thisisdano Here is what ours was looking like (Not too different!). Let me know if you have a preference and I can update the data.

image

@amyleadem
Copy link
Contributor Author

@thisisdano @sarah-sch I went ahead and included both the bulleted event details and the subtitle. I am going to come back through tomorrow morning to validate all of the data. Let me know if you want any changes to the template!

@amyleadem amyleadem dismissed sarah-sch’s stale review November 14, 2023 23:04

Clearing this review because we re-worked the page content and it needs new approval.

@amyleadem
Copy link
Contributor Author

Update: I ended up validating the data today instead. Let me know if you have questions!

Copy link
Contributor

@sarah-sch sarah-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @amyleadem, I'm requesting a few changes.

_data/monthly-calls.yml Outdated Show resolved Hide resolved
_data/monthly-calls.yml Outdated Show resolved Hide resolved
_data/monthly-calls.yml Outdated Show resolved Hide resolved
@amyleadem
Copy link
Contributor Author

amyleadem commented Nov 15, 2023

@sarah-sch and @thisisdano I have updated the layout to include the monthly calls from January-October 2023 and validated the data. Will you take a look and let me know what you think?

Copy link
Contributor

@sarah-sch sarah-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyleadem - sorry to keep adding changes - I am suggesting descriptions for the couple of months that don't have them. This change will make the different month entries more uniform.

_data/monthly-calls.yml Show resolved Hide resolved
_data/monthly-calls.yml Show resolved Hide resolved
@amyleadem
Copy link
Contributor Author

@sarah-sch
cc: @thisisdano

I've made the requested changes. Please let me know if you need anything else!

@thisisdano
Copy link
Member

Looks great to me, thank you!

@thisisdano thisisdano merged commit b104ce6 into main Nov 15, 2023
11 checks passed
@thisisdano thisisdano deleted the al-monthly-call-page branch November 15, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review content on USWDS Video Tutorials page
5 participants